search

fedora-infra / mirrormanager2

Rewrite of the MirrorManager application in Flask and SQLAlchemy
https://mirrormanager.fedoraproject.org
GNU General Public License v2.0
63 stars 46 forks source link

mirrorlist: add protocol option #172

Closed adrianreber closed 8 years ago

adrianreber commented 8 years ago

This adds the option specify the desired protocol of the mirrorlist/metalink as described in #100

The code is currently running in staging and the result can be seen at:

http://mirrors.stg.fedoraproject.org/mirrorlist?repo=rawhide&arch=x86_64&country=jp&protocol=rsync http://mirrors.stg.fedoraproject.org/mirrorlist?repo=rawhide&arch=x86_64&country=jp&protocol=ftp http://mirrors.stg.fedoraproject.org/metalink?repo=rawhide&arch=x86_64&country=gb&protocol=https http://mirrors.stg.fedoraproject.org/metalink?repo=rawhide&arch=x86_64&country=gb&protocol=rsync

pypingou commented 8 years ago

:+1: for me

nirik commented 8 years ago

Looks great! as a aside, we should likely ask mirrors to add more https links before we advertise this feaure. Or perhaps even scan all mirrors with http:// links and see how many support https and auto add those.

adrianreber commented 8 years ago

Yes, scanning for https URLs should be possible and also easier than the ftp URLs removal.

adrianreber commented 8 years ago

I scanned all http URLs and replaced 'http' with 'https' and added the result to the database. This increased the number of https URLs from 24 to 112. We have 920 http URLs in the database.

The metalink will start to redirect users to http and https URLs so people will be hitting more https mirrors in about 30 minutes.

I have not verified that the content provided via the same https URL is the same as the content from the http URL.