search

fedora-infra / mirrormanager2

Rewrite of the MirrorManager application in Flask and SQLAlchemy
https://mirrormanager.fedoraproject.org
GNU General Public License v2.0
63 stars 46 forks source link

Private URLs are now restricted to admins #198

Closed adrianreber closed 7 years ago

adrianreber commented 7 years ago

MirrorManager has the concept of private URLs which should be used for inter-mirror syncing. Unfortunately they are sometimes confused with the concept of private mirrors. Private URLs will never show up in the mirrorlist/metalink and if a private mirror (only for a certain network or host) marks a URL as private it will not show up.

As the private flag is not reflected anywhere on the web pages it can only be seen in the database.

With this change a private URL is now also displayed as private in the host category URL view and only admins can mark URLs as private.

Signed-off-by: Adrian Reber adrian@lisas.de

adrianreber commented 7 years ago

Trying to fix #149 as a mirror marked URLs as private and I was debugging it for hours.

pypingou commented 7 years ago

Looks fine to me

adrianreber commented 7 years ago

Thanks. Closes #149