search

fedora-infra / mirrormanager2

Rewrite of the MirrorManager application in Flask and SQLAlchemy
https://mirrormanager.fedoraproject.org
GNU General Public License v2.0
63 stars 46 forks source link

publiclist: hide disabled arches and products #223

Closed adrianreber closed 6 years ago

adrianreber commented 6 years ago

The original MirrorManager code base had the feature to hide certain arches and products from the publiclist. The database fields still exist and are even set to 'false' for certain arches.

There is the ticket https://pagure.io/fedora-infrastructure/issue/5186 which tried to remove unused architectures from the publiclist (sparc and sparc64). Using the now unused database column 'publiclist' seems like the right thing to do to hide certain arches (including source) from the publiclist. RPM Fusion which still uses the original MirrorManager code base is a good example how it used to look:

http://mirrors.rpmfusion.org/mm/publiclist/

The architecture 'source' is not displayed, which has in both instances (Fedora and RPM Fusion) publiclist = False. It still can be seen in Fedora:

https://admin.fedoraproject.org/mirrormanager/

I tested my changes in Fedora's staging instance and marked sparc, sparc64 and ia64 as publiclist=false in the database:

https://admin.stg.fedoraproject.org/mirrormanager/

Signed-off-by: Adrian Reber adrian@lisas.de

adrianreber commented 6 years ago

Fixes #210

mdomsch commented 6 years ago

I love that my old features are still being found like easter eggs!

On Oct 18, 2017 6:50 AM, "Adrian Reber" notifications@github.com wrote:

Fixes #210 https://github.com/fedora-infra/mirrormanager2/issues/210

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fedora-infra/mirrormanager2/pull/223#issuecomment-337565419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqDqkUeQ6ucM_8lLIta0vz-_by5Ks-Sks5steXTgaJpZM4P9ldT .

adrianreber commented 6 years ago

@mdomsch, thanks for all the easter eggs ;-) . It really helps to have RPM Fusion still running on the original code base to see how some things were supposed to work.