search

fedora-infra / mirrormanager2

Rewrite of the MirrorManager application in Flask and SQLAlchemy
https://mirrormanager.fedoraproject.org
GNU General Public License v2.0
65 stars 49 forks source link

Last Checked In shows stale timestamp on Public Hosts #287

Closed survient closed 4 years ago

survient commented 4 years ago

Since https://github.com/fedora-infra/mirrormanager2/commit/e63d9dfbe2b1544f85d2ef4ac3584cd10cda5a7c the "Last Checked In" field under a Public Hosts' properties shows a stale timestamp when from that commit's point forward the intent was for Public Hosts to no longer use report_mirror. On Public Hosts this field should either be hidden or show an appropriate value when "Private" is unchecked. Otherwise mirror owners may become confused(as I did) when seeing a recent "Last Crawled" but a stale "Last Checked In". I suppose the same logic could be applied in reverse for Private Hosts with the "Last Crawled" field.

adrianreber commented 4 years ago

Also a good idea. Thanks. Will fix it in the next release.