search

fedora-infra / mobile

An Android app that allows the Fedora community to interact with Fedora's web apps on the go.
https://fedoraproject.org/mobile
Other
27 stars 10 forks source link

Use datagrepper instead of HRF for Newsfeed. #42

Open relrod opened 9 years ago

relrod commented 9 years ago

HRF is being deprecated because datagrepper is better and does pretty much everything we need now (and does it way better than HRF did).

relrod commented 9 years ago

This isn't closable yet because there is likely some fallout from 51cf251. This also breaks the GCM code a bit because right now they share the JSON deserialization code but it is different on datagrepper and HRF. But since the GCM code isn't actually used right now (and can't be now, until fedora-infra/fmn.consumer#34 lands), committing this and letting it land in the CI build isn't a huge issue.

relrod commented 9 years ago

Also need to talk with @ralphbean next week and see about getting 'title' added to grouped messages. This might not work because of how 'grouped' works (can grouped messages have different title fields, or will they all be the same org.fedoraproject.prod.x.y.z?). But this is fairly low priority (well, at least as low as UI stuff is in general right now, in Mobile).

ralphbean commented 9 years ago

can grouped messages have different title fields?

I imagine they would have different title fields. Take for instance, badges. You might have three messages like "ricky got the foobar badge", "ricky got the fizbuzz badge", and "ricky advanced to position numbah 1" that could be combined into "ricky got the foobar and fizbuzz badges making him numbah 1".

Right now, the grouped messages return a list of the msg_ids of the constituent messages. We could move to instead providing a dict of those msg_ids that map to further metadata (the subtitle of each message, the title, etc..). I can see that being useful in lots of places -- imagine a UI that includes an "expand" button to expand a grouped message into a view of its constituents.

That change would just need to take place in fedmsg_meta (with a small docs change in fedmsg itself..).