search

fedora-infra / pagure-exporter

Simple exporter tool that helps migrate repository files, data assets and issue tickets from projects on Pagure to GitLab
GNU General Public License v3.0
6 stars 6 forks source link

tkts parameters are true by default #128

Open brngylni opened 8 months ago

brngylni commented 8 months ago

This relates to issue https://github.com/fedora-infra/pagure-exporter/issues/79. Parameters have been made True by default.

gridhead commented 8 months ago

@brngylni, in the /test/ directory - you need to make changes to account for the changed option sets.

Take, for instance, these lines of code https://github.com/fedora-infra/pagure-exporter/blob/main/test/test_tkts.py#L37-L48 where it is assumed that the labels, states, privacy, comments and orders are NOT transferred just because the said flags have not been enabled. This is no longer true with respect to your pull request as now these options default to true regardless of these things are passed or not. Therefore, the testcases need to be changed to accompany those. I will limit myself to explaining only one such scenario and allow for you to explore the codebase so that you can find out more such testcases that need changing.

brngylni commented 8 months ago

@brngylni, in the /test/ directory - you need to make changes to account for the changed option sets.

Take, for instance, these lines of code https://github.com/fedora-infra/pagure-exporter/blob/main/test/test_tkts.py#L37-L48 where it is assumed that the labels, states, privacy, comments and orders are NOT transferred just because the said flags have not been enabled. This is no longer true with respect to your pull request as now these options default to true regardless of these things are passed or not. Therefore, the testcases need to be changed to accompany those. I will limit myself to explaining only one such scenario and allow for you to explore the codebase so that you can find out more such testcases that need changing.

Thank you very much for the clarification. I've checked the test files and updated the commands accordingly. Hopefully there are no misses this time.