search

fedora-infra / pkgdb2

Updated version of the Package Database
https://admin.fedoraproject.org/pkgdb/
GNU General Public License v2.0
23 stars 26 forks source link

Making sure that the request states are not accidentally changed when user is admin #279

Closed trishnaguha closed 8 years ago

trishnaguha commented 8 years ago

I am not able to see the issue since I was unable to make myself admin in my local instance, let me know if this fixes #278 Thanks :)

pypingou commented 8 years ago

I'm not sure I agree with this change, it's a process that is blocked, not a state. Don't you think?

pypingou commented 8 years ago

I don't think this fixes the ticket #278, that ticket is asking to inform the admins that updating the status of a request does not actually process the request (ie: marking a branch request as approved does not actually create the new branch). The proper way to process requests is via the pkgdb-admin CLI tool.

ralphbean commented 8 years ago

@pypingou, I think @trishnaguha made the update in response to your request. Does it look okay now?

pypingou commented 8 years ago

Yes looks good and I checked, is_admin is defined so it'll work