search

fedora-infra / pkgwat.api

Python API for querying the Fedora Packages webapp
http://pkgwat.rtfd.org
Other
9 stars 9 forks source link

Update utils.py #25

Closed adsnjhfyeqw231eas closed 8 years ago

adsnjhfyeqw231eas commented 8 years ago

json object returned in #24

ralphbean commented 8 years ago

I'm confused about this change. Can you explain the reasoning behind it?

pypingou commented 8 years ago

@TridevGuha did you see @ralphbean's question?

ralphbean commented 8 years ago

I'm pretty sure that returning a str from strip_tags(...) instead of a dict is not what we want to do. So, I'm going to close this. @TridevGuha, if you want to explain and re-open it, feel free!

adsnjhfyeqw231eas commented 8 years ago

OK @ralphbean , I just returned the json object.

ralphbean commented 8 years ago

json.dumps returns a string in python. Any other code that previously called that function and tried to work with the return value would probably stop working. Before it was returning a dict and now it would be returning a str -- those things behave quite differently.

adsnjhfyeqw231eas commented 8 years ago

@ralphbean thanks, I will try to know more about it