fedora-infra / rpmautospec

Automatically generate release values and changelog entries from git history in RPM spec files

MIT License

4 stars 7 forks source link

Convert CLI from argparse to click #160

Closed nphilipp closed 3 months ago

nphilipp commented 3 months ago

Story

As a developer implementing autocompletion (#159) I want that command line arguments are processed by click rather than argparse, because it can do command line completion natively and allows better separation between main and subcommand arguments.

Acceptance Criteria

[x] The rpmautospec CLI uses click/-plugins for its subcommands, options and arguments.

Background

Click isn’t available in EL8, so would probably need a 0.6.x branch.

nphilipp commented 3 months ago

Compat considerations:

Availablity of click
Moderate UI changes with how click formats help, doesn’t return a non-zero exit code when called without a sub-command
More consistent function names (but compensated in the top level package)

yselkowitz commented 2 months ago

Please note that this pulls in click and click-plugins at runtime and click-man at buildtime. None of those three are included in RHEL, and this would necessitate adding them to RHEL (albeit as buildroot-only) for the sole purpose of supporting rpmautospec. Please consider reverting this change, or refactoring rpmautospec so that the parts needed in the buildroot do not require click.

/cc @sgallagher