search

fedora-infra / rpmautospec

Automatically generate release values and changelog entries from git history in RPM spec files
MIT License
4 stars 7 forks source link

Accommodate increased robustness in RPM 4.20 #182

Closed nphilipp closed 2 months ago

nphilipp commented 2 months ago

RPM prior to version 4.20 failed to parse some abridged spec files. Newer versions are more robust, so the fall back path won’t be used.

sgallagher commented 2 months ago

Should we be dropping this? Fedora 39 and 40 both have older versions of RPM and are still actively maintained. Same for several other RPM-based distributions...

nphilipp commented 1 month ago

@sgallagher Sorry for the late reply, didn’t notice your comment before I went on PTO…

Should we be dropping this? Fedora 39 and 40 both have older versions of RPM and are still actively maintained. Same for several other RPM-based distributions...

Ahh I realize how this change can be confusing – the original conditional break out of the loop was in place to work around coverage issues which seem to be solved since. All of these changes are only relevant for testing.