search

fedora-infra / supybot-fedora

Fedora plugin for Supybot
20 stars 23 forks source link

hardcode checks for g++ c++ and i++ #30

Closed ralphbean closed 9 years ago

ralphbean commented 9 years ago

so we don't award badges to them.. ;)

bitlord commented 9 years ago

I'm not sure do we need to exclude 'g', 'c' and 'i' as lowercase only or both? I did a small test script, which looks ok to me, this is the code https://github.com/bitlord/supybot-fedora/commit/cc3f8d4a4cd294f1becc7f3ebdec03f1c6a288fd

btw. this code should exclude both 'G++'/'g++' ...

bitlord commented 9 years ago

Also, do you think two ifs is too much, I can combine it into one I guess? ... if len(recip) == 1 and recip.capitalize() in ['C','G','I']: ...

ralphbean commented 9 years ago

I think this is good now and fixed with #36.