search

fedora-infra / supybot-fedora

Fedora plugin for Supybot
20 stars 23 forks source link

Make WorkerThread inherit from SupyThread #53

Closed progval closed 7 years ago

progval commented 7 years ago

SupyThread is only used for counting the number of threads, but it does not hurt to inherit from it.

pypingou commented 7 years ago

Code wise this seems fine (although iirc, we're not longer using supybot but a fork of it, so we'll need to make sure that it works with it).

On the curiosity front, does this bring us some advantages?

progval commented 7 years ago

As far as I know, only this:

10:07 <pinkieval> @threads
10:07 <Limnoria> I have spawned 204 threads; 2 threads are still currently active: HTTP Server and MainThread.
pypingou commented 7 years ago

Nice one to run in our instance: I have spawned 13192 threads; 1 thread is still currently active: MainThread. ^_^