fedora-infra / supybot-fedora

Fedora plugin for Supybot
20 stars 23 forks source link

Expand admonition when user tries to modify their own karma. #57

Closed aslicerh closed 3 years ago

relrod commented 6 years ago

I'm -1 for two reasons:

aslicerh commented 6 years ago

@relrod I can understand the annoyance with the 3 lines. I just figured it would be pretty rare that someone would try to deduct karma from themselves, so the joke might be ok.

Regarding hard coding the name, I can also agree with that, but it is done in other places in the plugin (localtime) so I figured it was the accepted procedure. I didn't notice anywhere else that the bots name was used, so what is the suggested way to know the bots name?

relrod commented 6 years ago

I think conf.supybot.nick would work (at least it does in a quick test), although it doesn't seem to update if someone changes the nick while the bot is running.

And yeah, I don't think localtime should hardcode the nick either...

ryanlerch commented 3 years ago

closing this off due to inactivity. please reopen if still desired