search

fedora-infra / tahrir

Pyramid app for issuing your own Open Badges
https://badges.fedoraproject.org/
Other
76 stars 54 forks source link

Fix #352 #540

Closed Bprathmesh closed 2 months ago

Bprathmesh commented 3 months ago

Updated 404 and 500 error pages with descriptive text and improved styling.

penguinpee commented 3 months ago

Thank you @Bprathmesh. Could you flip subject and body of your commit message, please. The subject should be a brief description of what the commit does. Also, having PR #352 mentioned in the body will link this PR to the original issue, making navigation easier as well as having the issue closed once the PR is merged.

Otherwise the change looks fine to me. Could you leave a comment regarding your motivation to change from single to double quotes in some places?

Bprathmesh commented 3 months ago

@penguinpee Thank you for the feedback!

I will update the commit message to follow the suggested format. Here’s how I’ll revise it:

Subject: Update 404 and 500 error pages with descriptive text and improved styling

Body: Fixes #352 by updating the 404 and 500 error pages to include meaningful text alongside the centered images. This change improves user experience by providing clear information about the errors and potential next steps.

Regarding the change from single to double quotes in some places, I used double quotes for consistency with the rest of the HTML and CSS files in the project. I’ll add this explanation in the commit message or comments for clarity.

I’ll make these updates and push the changes. Thanks again!

abompard commented 2 months ago

Hey! I didn't see this PR and accidentally started working on the same issue, and I'm noticing it now that I've pushed a PR. :-( Since I made some other change in my PR such as merging the two error pages into one, I'm going to keep mine. I've incorporated some of your error phrases so that your work doesn't entirely go to waste. I'm very sorry :-(

Superseded by #541