change packaging to not require default health check scripts

fedora-iot / greenboot

Generic Health Checking Framework for systemd

GNU Lesser General Public License v2.1

101 stars 29 forks source link

change packaging to not require default health check scripts #117

Closed miabbott closed 2 months ago

miabbott commented 1 year ago

The currently available default health check scripts which are required do not have the level of reliability we desire for Edge device scenarios.

See #68, #71, #90, #93, #98 for examples of difficulties, failures, etc of the scripts

Until we are able to provide more resilient health checks by default, we should package the existing scripts in a separate RPM and have it be an optional install.

say-paul commented 1 year ago

The health-check is distributed as separate package. But installed by default via image-builder for r4e

miabbott commented 1 year ago

But installed by default via image-builder for r4e

Thanks for pointing that out; I'd say we should stop including the subpackage by default in Fedora IoT/R4E until we have more confidence in health checks.

say-paul commented 1 year ago

PR: https://github.com/osbuild/images/pull/179

7flying commented 1 year ago

I might have understood yesterday's discussion differently, I thought that we were going to leave the default health checks as they are, since internet connectivity is usually part of the critical path, and we were going to think about how to implement #119 , so I don't think that we should do osbuild/images#179

say-paul commented 1 year ago

Yes, We would be looking for options to make it configurable, I would still keep the PR until we decide how to package the default-health-check if we want configure it from greenboot.

7flying commented 1 year ago

Ideas:

We agree that we should not remove the default checks RPM.
We should configure the checks two ways: is it enabled/disabled (use a list for this), and is it required or wanted (in case that it is enabled).
We are going to use a single config file instead of using directories to express configuration.

Other things to consider:

How are we going to handle "old" greenboot versions that still have the required.d and wanted.d ?
How are we going to handle config upgrades with new health checks?
How are we going to handle health checks provided by the user?

Future:

Allow overriding "default" config file if another file is found at X directory.

say-paul commented 2 months ago

addressed with #137