fedora-iot / greenboot

Generic Health Checking Framework for systemd
GNU Lesser General Public License v2.1
101 stars 29 forks source link

chore: update packit config #121

Closed nullr0ute closed 1 year ago

nullr0ute commented 1 year ago

Update packit configs to build all current Fedora releases so we don't need to update this file.

pcdubs commented 1 year ago

LGTM

7flying commented 1 year ago

Are the "testing-farm:fedora-37-x86_64 — Test job requires build job definition in the configuration." warnings on the Github CI thing something expected?

LorbusChris commented 1 year ago

@7flying expected no, but this change shouldn't affect the pre-commit tests at all. Idk, maybe a packit limitation when the config file is touched? Should see on other PRs whether this persists..

7flying commented 1 year ago

@7flying expected no, but this change shouldn't affect the pre-commit tests at all. Idk, maybe a packit limitation when the config file is touched? Should see on other PRs whether this persists..

Good point, let's wait and see

lachmanfrantisek commented 1 year ago

Are the "testing-farm:fedora-37-x86_64 — Test job requires build job definition in the configuration." warnings on the Github CI thing something expected?

@LorbusChris @7flying @nullr0ute Hello! The information is correct.

By default, the test job requires a Copr build job so the RPMs are installed in the VM where the tests are run. (We currently don't support the Koji build with tests -- please, open a new issue if you think this should be implemented)

You can either define a new Copr build:

  - job: copr_build
    trigger: pull_request
    targets:
      - fedora-all

Or, if you don't need the build and want to run just tests, you can use skip_build option for tests to run just tests.

And one note about test definition: