fedora-iot / greenboot

Generic Health Checking Framework for systemd
GNU Lesser General Public License v2.1
101 stars 29 forks source link

Add static grub config #129

Closed cgwalters closed 9 months ago

cgwalters commented 1 year ago

This pairs with https://github.com/coreos/bootupd/pull/543 to have bootupd support injecting the greenboot grub logic only if greenboot is installed.

nullr0ute commented 1 year ago

How does this impact users that may not have moved to bootupd/unified core yet?

LorbusChris commented 1 year ago

To add some more context: This config snippet originates with grub2-tools, but it's excluded in FCOS. I'm not familiar with the reasons of osbuild carrying another copy of that snippet.

Desktop variants currently use:

How would these snippets be shipped for e.g. the Silverblue ostree native container image? Do all the snippets have to shipped in /usr/lib/bootupd/grub2-static/configs.d/ going forward in order to work with bootupd? How are they ordered?

Should 08_fallback_counting be removed from grub2-tools after this merges to make this repo here the canonical location?

cgwalters commented 1 year ago

How does this impact users that may not have moved to bootupd/unified core yet?

If bootupd isn't used (as it's not today for IoT/Edge) there is zero impact other than a small new file in /usr that is unused.

To add some more context: This config snippet originates with grub2-tools, but it's excluded in FCOS. I'm not familiar with the reasons of osbuild carrying another copy of that snippet.

So one thing going on here is many of us really want a "static grub config" where we don't run grub2-mkconfig and especially not os-prober for every kernel update.

cgwalters commented 9 months ago

cc https://github.com/ostreedev/ostree/pull/3162#issuecomment-1934679505

runcom commented 9 months ago

Given low impact as per https://github.com/fedora-iot/greenboot/pull/129#issuecomment-1779710159 and since we're moving to bootupd, this ease with testing that flow too.

lgtm