search

fedora-iot / greenboot

Generic Health Checking Framework for systemd
GNU Lesser General Public License v2.1
101 stars 29 forks source link

The /etc/greenboot/greenboot.conf file is overwritten when upgrading / downgrading the package #142

Closed ggiguash closed 4 months ago

ggiguash commented 5 months ago

The /etc/greenboot/greenboot.conf file is overwritten when upgrading / downgrading the package. This prevents from user customizations to persist following an OS upgrade.

  1. sudo dnf downgrade -y greenboot
  2. Edit or create /etc/greenboot/greenboot.conf 
    # grep -vE '^$|^#' /etc/greenboot/greenboot.conf 
GREENBOOT_MAX_BOOT_ATTEMPTS=1
GREENBOOT_WATCHDOG_CHECK_ENABLED=true
  3. sudo dnf upgrade -y greenboot
  4. Check the file contents 
    # grep -vE '^$|^#' /etc/greenboot/greenboot.conf 
GREENBOOT_WATCHDOG_CHECK_ENABLED=true
nullr0ute commented 5 months ago

Good catch, we need to label that as a config so it doesn't do that. Will have a fix shortly.

nullr0ute commented 5 months ago

This should be fixed with this update: https://bodhi.fedoraproject.org/updates/FEDORA-2024-db58423740

I've tagged it so it'll appear in the next F-40 compose.

ggiguash commented 5 months ago

Thank you, @nullr0ute, for the quick fix!

miabbott commented 5 months ago

I was curious about the commit, so here you go - https://src.fedoraproject.org/rpms/greenboot/c/8e29d4027242c0ffbf1007963ae84b92c278fb74?branch=rawhide

nullr0ute commented 5 months ago

I was curious about the commit, so here you go - https://src.fedoraproject.org/rpms/greenboot/c/8e29d4027242c0ffbf1007963ae84b92c278fb74?branch=rawhide

This was the main fix, I did some other cleanup:

say-paul commented 4 months ago

Closing this as the issue is fixed.