search

fedora-iot / greenboot

Generic Health Checking Framework for systemd
GNU Lesser General Public License v2.1
101 stars 29 forks source link

Should all the greenboot-* systemd services be enabled? #91

Closed alcir closed 1 year ago

alcir commented 1 year ago

https://github.com/fedora-iot/greenboot/blob/650ce7724b5394c5a50c8428dd193260e3127870/README.md?plain=1#L36

Do greenboot-rpm-ostree-grub2-check-fallback greenboot-grub2-set-counter redboot-task-runner redboot-auto-reboot should be enabled as well?

7flying commented 1 year ago

No, those are only triggered when a health check fails and handle the reboot/rollback of your system.

alcir commented 1 year ago

mmm, are you sure? Because if I leave them disabled (I was performing some test on Fedora Silverblue), greenboot doesn't work as described. In addition, on Fedora IoT (if I'm not wrong) these services seem to be enabled.

nullr0ute commented 1 year ago

mmm, are you sure? Because if I leave them disabled (I was performing some test on Fedora Silverblue), greenboot doesn't work as described. In addition, on Fedora IoT (if I'm not wrong) these services seem to be enabled.

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

alcir commented 1 year ago

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

So in a system without such presets, they should be manually enabled?

nullr0ute commented 1 year ago

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

So in a system without such presets, they should be manually enabled?

Not all, just the ones specified in the presets.

alcir commented 1 year ago

Yes. Looking at /usr/lib/systemd/system-preset/80-iot.preset, what I mean in this issue is: in the readme, in addition to greenboot-task-runner greenboot-healthcheck greenboot-status greenboot-loading-message also greenboot-rpm-ostree-grub2-check-fallback greenboot-grub2-set-counter redboot-task-runner redboot-auto-reboot should be added. Isn't it?

LorbusChris commented 1 year ago

@alcir all the greenboot-* services present in 80-iot.preset should be added to the README for completeness. Feel free to open a PR.

It does looks like greenboot-loading-message.service is not currently enabled in the preset file. I'm not sure whether that's intended or an oversight, in which case it should probably be added to the preset.

alcir commented 1 year ago

It does looks like greenboot-loading-message.service is not currently enabled in the preset file. I'm not sure whether that's intended or an oversight, in which case it should probably be added to the preset.

https://src.fedoraproject.org/rpms/fedora-release/pull-request/245

Thank you all.