Further improve java-functions to work without JAVA_HOME

fedora-java / javapackages

Macros and scripts for Java packaging support

Other

7 stars 15 forks source link

Further improve java-functions to work without JAVA_HOME #120

Closed mizdebsk closed 2 weeks ago

mizdebsk commented 2 weeks ago

Remove JAVA_HOME check from check_java_env function - follow up on #119
Obsolete public functions set_jvm and set_jvm_dirs - they do nothing
Remove private function _set_java_home

CC @fridrich

mizdebsk commented 2 weeks ago

Also search for JAVACMD under JAVA_HOME only if it's set - otherwise ${JAVA_HOME}/bin/java expands to just /bin/java and likely matches some Java, possibly different one than from PATH via which.

fridrich commented 2 weeks ago

I also think that this would actually justify a 6.3.2 if all the scripts are cleaned up. It is such an improvement.

mizdebsk commented 2 weeks ago

I also think that this would actually justify a 6.3.2

I will make a release with current fixes/improvements.

There is another one I'd like to do (#121), but it's a potentially breaking change, so I'll defer it to 7.0.0