fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

Remove reference to %{java_home} from commands #129

Closed fridrich closed 1 week ago

fridrich commented 1 week ago

The %ant, %jar %javadoc %javac commands make little sense but they might be in spec files around the place. Make them just straight ant, jar, javadoc and javac as a stop-gap solution. Would be nice to echo before that they are deprecated, but that would be a lot of noise in the rpm build.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.00%. Comparing base (3471e50) to head (b9eaeab). Report is 17 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ======================================= Coverage 91.00% 91.00% ======================================= Files 45 45 Lines 3401 3401 ======================================= Hits 3095 3095 Misses 306 306 ``` | [Flag](https://app.codecov.io/gh/fedora-java/javapackages/pull/129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fedora-java) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/fedora-java/javapackages/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fedora-java) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fedora-java#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mizdebsk commented 1 week ago

In Fedora and RHEL we do set %java_home macro and we want to use the commands from %java_home and not from $PATH. Therefore these macros are still relevant to us. Instead I propose to fall back to straight commands when %java_home is not defined. I'll open PR for that.

mizdebsk commented 1 week ago

My alternative proposal is at #132

fridrich commented 1 week ago

Closing in favour of #132