search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

Add coverage report #23

Closed mizdebsk closed 8 years ago

mizdebsk commented 8 years ago

Fixes #22

codecov-io commented 8 years ago

Current coverage is 87.96% (diff: 100%)

No coverage report found for master at 18e0c61.

Powered by Codecov. Last update 18e0c61...53e4c6f

mizdebsk commented 8 years ago

Note that this only covers nosetests in test/ directory, not python/test/, that's one reason for so low coverage. Can anyone explain me why we have two set of tests at different locations, ran in different ways?

msimacek commented 8 years ago

python/test/ should be unit tests for the python module test/ are (mostly) integration tests for the macros and scripts. I'm not sure if meaningful coverage data can be generated for them, because the scripts are exec'd, sometimes even indirectly via rpmbuild

mizdebsk commented 8 years ago

It looks like coverage of subprocesses shouldn't be hard, http://coverage.readthedocs.io/en/coverage-4.1/subprocess.html

mizdebsk commented 8 years ago

Current coverage is 87.96% (diff: 100%)

Now, that's better :)

I think this is ready to be merged. @msimacek Any further comments?

msimacek commented 8 years ago

Looks great, thank you :)