search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

Replace bash code with proper python code #45

Closed rvais closed 6 years ago

rvais commented 7 years ago

Solves issue #12

codecov-io commented 7 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.18%. The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   89.75%   89.57%   -0.19%     
==========================================
  Files          44       44              
  Lines        3154     3164      +10     
==========================================
+ Hits         2831     2834       +3     
- Misses        323      330       +7
Impacted Files Coverage Δ
java-utils/mvn_build.py 78.09% <41.66%> (-5.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c150cb4...0712e97. Read the comment docs.

rvais commented 7 years ago

I created a test case but unfortunately it works only for python 3. For python 2 it fails due to differences in gzip module between python versions. I will redo it after I figure out how to make it produce the same output in case of python 2.

msimacek commented 6 years ago

Almost a year without any activity. Closing. Feel free to reopen

rvais commented 6 years ago

Yeah. I completely forgot about this old issue since I left the team and started to work for Messaging QE ... If I find a bit of time I will finish it. I have more experience with python now, which should help.