search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

[mvn_artifact] Provide more helpful error messages #47

Closed msimacek closed 7 years ago

msimacek commented 7 years ago

This:

error: The first argument 'output/dist/lib/asm-all-6.0.pom' doesn't point to an existing file nor it looks like an artifact string

is IMO better than this:

Traceback (most recent call last):
  File "/usr/share/java-utils/mvn_artifact.py", line 250, in _main
    uart = Artifact.from_mvn_str(args[0])
  File "/usr/lib/python3.6/site-packages/javapackages/maven/artifact.py", line 350, in from_mvn_str
    p = Artifact.get_parts_from_mvn_str(mvnstr)
  File "/usr/lib/python3.6/site-packages/javapackages/maven/artifact.py", line 84, in get_parts_from_mvn_str
    .format(mvnstr=mvnstr))
javapackages.maven.artifact.ArtifactFormatException: Artifact string 'output/dist/lib/asm-all-6.0.pom' does not contain ':' character. Can not parse

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/share/java-utils/mvn_artifact.py", line 315, in <module>
    _main()
  File "/usr/share/java-utils/mvn_artifact.py", line 259, in _main
    if is_it_ivy_file(args[0]):
  File "/usr/share/java-utils/mvn_artifact.py", line 113, in is_it_ivy_file
    doc = et.parse(fpath)
  File "src/lxml/lxml.etree.pyx", line 1885, in lxml.etree._ElementTree.parse (src/lxml/lxml.etree.c:63960)
  File "src/lxml/parser.pxi", line 1811, in lxml.etree._parseDocument (src/lxml/lxml.etree.c:118635)
  File "src/lxml/parser.pxi", line 1837, in lxml.etree._parseDocumentFromURL (src/lxml/lxml.etree.c:118982)
  File "src/lxml/parser.pxi", line 1741, in lxml.etree._parseDocFromFile (src/lxml/lxml.etree.c:117894)
  File "src/lxml/parser.pxi", line 1138, in lxml.etree._BaseParser._parseDocFromFile (src/lxml/lxml.etree.c:112440)
  File "src/lxml/parser.pxi", line 595, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:105896)
  File "src/lxml/parser.pxi", line 706, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:107604)
  File "src/lxml/parser.pxi", line 633, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:106415)
OSError: Error reading file 'output/dist/lib/asm-all-6.0.pom': failed to load external entity "output/dist/lib/asm-all-6.0.pom"
codecov-io commented 7 years ago

Codecov Report

Merging #47 into master will increase coverage by 0.01%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   89.94%   89.96%   +0.01%     
==========================================
  Files          44       44              
  Lines        3154     3159       +5     
==========================================
+ Hits         2837     2842       +5     
  Misses        317      317
Impacted Files Coverage Δ
java-utils/mvn_artifact.py 86.18% <94.44%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a6c462...ce82d59. Read the comment docs.