search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

[mvn_build] Add jvmargs to GRADLE_OPTS to prevent daemon mode #48

Closed msimacek closed 6 years ago

msimacek commented 7 years ago

When gradle.properties sets org.gradle.jvmargs that are different from current jvm flags, gradle forks a daemon even when you pass --no-daemon, which is unnecessary and makes debugging crashed builds harder. This change should prevent it.

codecov-io commented 7 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.96%   90.13%   +0.17%     
==========================================
  Files          44       44              
  Lines        3159     3174      +15     
==========================================
+ Hits         2842     2861      +19     
+ Misses        317      313       -4
Impacted Files Coverage Δ
java-utils/mvn_build.py 89.09% <100%> (+5.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f3a222...0956f1d. Read the comment docs.

mizdebsk commented 7 years ago

I understand what this code does, but I'm not sure what you are trying to achieve with it. Is it only about improving performance slightly and making debugging of crashed builds easier? IMHO that's not a good justification for maintaining this not-so-nice code.

What about simply removing gradle.properties and relying on default settings? From what I can see that file contains nothing but settings specific to systems Gradle is ran on.

msimacek commented 6 years ago

You're probably right, let's keep it the current way.