search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

Remove resolverSettings/prefixes from XMvn config #53

Closed mizdebsk closed 6 years ago

mizdebsk commented 6 years ago

This XMvn option has been ignored by XMvn for more than 4 years, since April 2014, when it switched to artifact resolution from metadata files instead of configured artifact repositories. Removing this option from our configs will allow XMvn to eventually deprecate it.

codecov-io commented 6 years ago

Codecov Report

Merging #53 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          43       43           
  Lines        3150     3150           
=======================================
  Hits         2839     2839           
  Misses        311      311

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 631f909...0bdadc4. Read the comment docs.

mizdebsk commented 6 years ago

To be precise, resolver prefixes actually started to be ignored after removal of depmaps in https://github.com/fedora-java/xmvn/commit/47b6a026abfb66a7f392158db84754fbe747cf96 (Jan 26, 2015), but resolver prefixes were deprecated together with depmaps on April 1, 2014 in https://github.com/fedora-java/xmvn/commit/386d8988f20f332c0973d7c80e08a145834bc1ae