search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

Rename the async kwarg in call_script to wait (reverses the logic) #59

Closed hroncok closed 6 years ago

hroncok commented 6 years ago

async is a reserved keyword in Python 3.7 and keeping it results in syntax error. I didn't want to rename the argument to asynch or async_ without thinking, so I've checked what it does and went with wait. I reversed the logic because I didn't want it to be nowait.

Feel free to rename it differently, but please do.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1592988

codecov-io commented 6 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          43       43           
  Lines        3150     3150           
=======================================
  Hits         2839     2839           
  Misses        311      311

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 838a1f8...4eb22a3. Read the comment docs.