search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

[pom_editor] Remove usage of introspection #65

Closed msimacek closed 6 years ago

msimacek commented 6 years ago

inspect.getargspec is deprecated in Python 3.6 and alternatives are not available on Python 2.7, so I chose to eliminate introspection usage altogether and use explicit arguments. It was too magic anyway.

codecov-io commented 6 years ago

Codecov Report

Merging #65 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   90.12%   90.12%   -0.01%     
==========================================
  Files          43       43              
  Lines        3150     3148       -2     
==========================================
- Hits         2839     2837       -2     
  Misses        311      311
Impacted Files Coverage Δ
java-utils/pom_editor.py 96.4% <100%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a445c62...ace9109. Read the comment docs.

mizdebsk commented 6 years ago

Looks good, thanks.