search

fedora-java / javapackages

Macros and scripts for Java packaging support
Other
7 stars 15 forks source link

rpm changes in rawhide break xmvn-builddep #72

Closed decathorpe closed 5 years ago

decathorpe commented 5 years ago

With a recent RPM change (possibly related to parallel processing of some sections), xmvn-builddep now sometimes fails to parse build.log files, depending on the timing of some output.

For example, for this build, xmvn-builddep obviously can't parse the dependencies, because rpm injects some garbage into the build dependencies block:

-----BEGIN MAVEN BUILD DEPENDENCIES-----
H4sIAAAAAAACA72UTU+EMBCG7/srKveC3lk26omDp42J15GOUEOnTT8I++8tgi4ag5t15dTM9Enf
eTvT5rtetaxD66SmbXKTXicMqdJCUr1NHvf8dn9flsmu2ORXnL+ RPM_EC=0
++ jobs -p
+ exit 0
O7IFvBBBokETGJjtVIaMGjYM8H
9vTQEeM80nOm2DB2TByGMCZqq4MpRaFtnYKBqsFUQYeUmjbUklyefRAjD9bLF6h8TLxz/JOb7Ywo
9h5pcFQYrfLsGA6FZF8r+bfCpuV7eefr/6qrtMB2Rb3JJxi5omilLV5Obuop91q3JzcWiLQHHwfK
rWgcbNXI+FL/JhmfNjYQXDSOfViyPAIXkv3xztH5+M2ceusTzhuwhM6tOnLKgD9f8DWQ9Asq0/7S
8bNo+FDfAIRD7pK3BQAA
-----END MAVEN BUILD DEPENDENCIES-----

Do you know if there's anything I / xmvn can do to work around this issue?

EDIT: I mean, besides manually editing build.log to fix fix, obviously :)

mizdebsk commented 5 years ago

Implementing #12 should fix this - the whole output would need to be atomically written to stdout to prevent rpm interleaving it with unrelated lines.

decathorpe commented 5 years ago

Should I send you a PR implementing this? It seems simple enough.

decathorpe commented 5 years ago

RPM in fedora 31+ got fixed, so this isn't a problem anymore.