Closed mkoncek closed 2 years ago
The script cannot be interpreted by the current rpmlua
present in Fedora Rawhide (version: RPM version 4.18.0-alpha2
)
1) It complains about shebang
2) arg
variable passing does not seem implemented so it is impossible to pass CLI args to the script.
Why use rpmlua instead of plain lua? Requirement on RPM 4.18 is a no-go for now, we still need to support RPM 4.14. We can't even use RPM 4.16 features such as parametric dependency generators, or meta-requires. Otherwise looks good.
I've fixed CI, it should run tests once you rebase the PR. Please remove use of rpmlua and I'll merge the PR.
Merging #90 (df23120) into master (38e4a3a) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head df23120 differs from pull request most recent head 2e10481. Consider uploading reports for the commit 2e10481 to get more accurate results
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 43 43
Lines 3009 3009
=======================================
Hits 2699 2699
Misses 310 310
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
I separated the functions from wrappers so that it should work with both lua and rpmlua. So that for example javapackages in Fedora Rawhide can be patched downstream to use rpmlua.
Note that rpmlua
does not inspect paths listed in LUA_PATH
. This can be worked around either by manually adding a line into the script before require
clause:
package.path = package.path..";<PATH>"
or by installing the library into /usr/lib/rpm/javapackages-tools/lua/...
although I haven't tested this.
I added a bunch of commits so that they are more easily reviewed. Should I squash them later?
There is no need to squash commits. Merged.
Requires: rpm >= 4.18 (for
/usr/bin/rpmlua
)Tested on package
guava
:Diff after using it on the Fedora package
classpathless-compiler
: