codecov-commenter
commented
1 year ago Codecov Report
Merging #98 (c3818d3) into master (cc0a7e0) will increase coverage by
0.03%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 90.96% 91.00% +0.03%
==========================================
Files 45 45
Lines 3397 3400 +3
==========================================
+ Hits 3090 3094 +4
+ Misses 307 306 -1 | Files | Coverage Δ | |
|---|---|---|
| java-utils/install_pom.py | 95.12% <100.00%> (+0.09%) |
:arrow_up: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
fridrich
mizdebsk
Some artifacts have things like
<artifactId>whatever_${scala.binary.version}</artifactId>. The variable normally is defined either in the current pom or in one of its parents. When generating simplified (dependencies-only) pom, interpolate this kind of variables in the current artifact coordinates too. This would need to be done eventually for mvn_artifact.py too. I tried but did not try a simple elegant way to do it, since the gathering of dependencies happen when the metadata artifact is already intitialized. But eventually one could create a maven artifact from the uart string, interpolate and push the 3 fields back to the metadata artifact. Or create a setter for it in the class.