search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
128 stars 39 forks source link

"command" module installed as root module #112

Closed glensc closed 7 years ago

glensc commented 7 years ago

i believe the "command" module should be installed as "pyp2rpm.command", not root level module "command":

/usr/share/python2.7/site-packages/command
/usr/share/python2.7/site-packages/command/__init__.pyc
/usr/share/python2.7/site-packages/command/__init__.pyo
/usr/share/python2.7/site-packages/command/extract_dist.pyc
/usr/share/python2.7/site-packages/command/extract_dist.pyo
/usr/share/python2.7/site-packages/pyp2rpm
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/PKG-INFO
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/SOURCES.txt
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/dependency_links.txt
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/entry_points.txt
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/requires.txt
/usr/share/python2.7/site-packages/pyp2rpm-3.2.2-py2.7.egg-info/top_level.txt
/usr/share/python2.7/site-packages/pyp2rpm/__init__.pyc
/usr/share/python2.7/site-packages/pyp2rpm/__init__.pyo
/usr/share/python2.7/site-packages/pyp2rpm/archive.pyc
/usr/share/python2.7/site-packages/pyp2rpm/archive.pyo
...
hroncok commented 7 years ago

From what I see in the code, this is how it is done. However I agree that it is wrong. Especially because there is a command package on PyPI.

glensc commented 7 years ago

yes, the code works. just packaging is incorrect.