search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
123 stars 39 forks source link

Add --skip-check option to omit test dependencies and %check section. #205

Open gordonmessmer opened 4 years ago

gordonmessmer commented 4 years ago

Adds the --skip-check option proposed in issue #162

hroncok commented 4 years ago

I am not very fond of this change. It promotes bad habits. If we cannot run %check, it shall be bconded out, not removed.

gordonmessmer commented 4 years ago

So that I'm clear, you're suggesting that --skip-check should add a bcond, right? Or do you mean that we shouldn't add the --skip-check option at all?

Assuming the former, should the bcond default to not running the checks? That is, do we assume that the checks are being skipped because they won't work in mock by default (because they need network access, for example?)

hroncok commented 4 years ago

Either not adding this at all, or it should add a bcond, disabled by default.