Specify distro for new Convertor test.

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.

MIT License

123 stars 39 forks source link

Specify distro for new Convertor test. #212

Closed gordonmessmer closed 4 years ago

gordonmessmer commented 4 years ago

PR 195 was merged, but did not have the "distro" argument in its tests, which is required since the merge of PR 199. This change fixes that deficiency.

hroncok commented 4 years ago

I don't mind the change, but the tests blew up about spec2scl.

gordonmessmer commented 4 years ago

I noticed that. I don't think it's related to changes in this project. It's probably the result of some change in spec2scl dropping support for py27. I'll look into it further as soon as I can. Since we plan to stop testing py27 anyway, we can probably just specify a maximum version for that package temporarily, until we get around to removing those tests.

gordonmessmer commented 4 years ago

The problem occurred in a couple of different Travis builds, but I was unable to reproduce it in my own environment today. I restarted the Travis build, and it doesn't look like it's happening now.

gordonmessmer commented 4 years ago

This change should resolve the test failures in 206 and 209.