search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
123 stars 39 forks source link

Discontinue removing bundled egg-info. #232

Open gordonmessmer opened 4 years ago

hroncok commented 4 years ago

Is has_bundled_egg_info unused now?

The proper fixer might be to only do this if there are binaries inside. However that might be tedious.

I strongly suggest to put the rationale into the commit message. The lack of rationale for adding this in the first place is now hurting. 8 years from now, somebody might wonder why was this removed and we could be long gone.

gordonmessmer commented 4 years ago

Is has_bundled_egg_info unused now?

Seems to be. I waffled on removing it, but I suppose there wouldn't be a reason not to... We can always pull it back from history.

The proper fixer might be to only do this if there are binaries inside. However that might be tedious.

I can look into that. Do you happen to know an example of a package that's published with binaries inside?

I strongly suggest to put the rationale into the commit message.

Definitely.

hroncok commented 4 years ago

Do you happen to know an example of a package that's published with binaries inside?

I don't, really. Let's say we don't do this until proven otherwise?

gordonmessmer commented 1 year ago

Reference, in case anyone reviews this in the future:

https://bugzilla.redhat.com/show_bug.cgi?id=1825455#c2