fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
128 stars 39 forks source link

Better parsing of README files in RST format #238

Open andy-maier opened 4 years ago

andy-maier commented 4 years ago

In our Pypi packages, we often have README files in RST format. pyp2rpm seems to simply copy the first few line of the README file into the generated RPM file, without parsing it to eliminate RST comments.

For an example, look at https://raw.githubusercontent.com/pywbem/pywbem/master/README_PYPI.rst. Here is what pyp2rpm generates from that:

%description
.. README file for Pypi.. Note: On Pypi, variable substitution with raw content
is not enabled, so .. we have to specify the package version directly in the
links... begin of customization for the current version .. |pywbem-version-mn|
replace:: 0.17 .. _Readme file on GitHub: .. _Documentation on RTD: .. _Change
log on RTD: .. end of customization for the current versionPywbem is a WBEM...

It does not even get beyond the comment section.

Proposal:

gordonmessmer commented 3 years ago

I'm unable to reproduce the behavior you're reporting, which will make it difficult to address the request. When I run simply "pyp2rpm pywbem", the %description sections don't appear to contain any RST markup.

How are you invoking the application?

nkadel commented 2 years ago

I can confirm that this is aproblem with a fresh pyp2rpm on RHEL 8.