3.3.4 doesn't find a prerelease passed as vesion unless --prerelease is passed

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.

MIT License

123 stars 39 forks source link

3.3.4 doesn't find a prerelease passed as vesion unless --prerelease is passed #243

Closed evgeni closed 3 years ago

evgeni commented 3 years ago

since the introduction of --prerelease one has to pass it even if -v already got a fixed prerelease version.

I think --prerelease should only affect "search the latest release" and not "use this fixed version" codepaths.

example:

% ./mybin.py -v 4.2.0rc1 galaxy-ng
Package "galaxy-ng" could not be found on PyPI.

% ./mybin.py -v 4.2.0rc1 --prerelease galaxy-ng
# Created by pyp2rpm-3.3.4
%global pypi_name galaxy-ng
…

gordonmessmer commented 3 years ago

This should be fixed in #245