search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
127 stars 39 forks source link

Merge of bdist devel branch to master #36

Closed mcyprian closed 8 years ago

mcyprian commented 8 years ago

Following changes were performed:

hroncok commented 8 years ago

You don't follow PEP8 very much:

$ git diff master..bdist_devel | python3-pep8 --diff
./pyp2rpm/archive.py:136:17: E122 continuation line missing indentation or outdented
./pyp2rpm/archive.py:138:80: E501 line too long (81 > 79 characters)
./pyp2rpm/archive.py:172:80: E501 line too long (98 > 79 characters)
./pyp2rpm/archive.py:175:80: E501 line too long (88 > 79 characters)
./pyp2rpm/bin.py:41:80: E501 line too long (99 > 79 characters)
./pyp2rpm/bin.py:68:80: E501 line too long (94 > 79 characters)
./pyp2rpm/convertor.py:79:1: W293 blank line contains whitespace
./pyp2rpm/convertor.py:158:80: E501 line too long (85 > 79 characters)
./pyp2rpm/convertor.py:163:80: E501 line too long (85 > 79 characters)
./pyp2rpm/convertor.py:174:80: E501 line too long (86 > 79 characters)
./pyp2rpm/extract_distribution.py:1:1: E902 FileNotFoundError: [Errno 2] No such file or directory: './pyp2rpm/extract_distribution.py'
./pyp2rpm/logger.py:9:80: E501 line too long (88 > 79 characters)
./pyp2rpm/logger.py:21:80: E501 line too long (81 > 79 characters)
./pyp2rpm/metadata_extractors.py:9:80: E501 line too long (80 > 79 characters)
./pyp2rpm/metadata_extractors.py:32:33: E225 missing whitespace around operator
./pyp2rpm/metadata_extractors.py:44:80: E501 line too long (86 > 79 characters)
./pyp2rpm/metadata_extractors.py:52:80: E501 line too long (94 > 79 characters)
./pyp2rpm/metadata_extractors.py:53:50: E261 at least two spaces before inline comment
./pyp2rpm/metadata_extractors.py:55:80: E501 line too long (96 > 79 characters)
./pyp2rpm/metadata_extractors.py:71:80: E501 line too long (98 > 79 characters)
./pyp2rpm/metadata_extractors.py:77:80: E501 line too long (91 > 79 characters)
./pyp2rpm/metadata_extractors.py:79:80: E501 line too long (86 > 79 characters)
./pyp2rpm/metadata_extractors.py:87:80: E501 line too long (91 > 79 characters)
./pyp2rpm/metadata_extractors.py:98:80: E501 line too long (85 > 79 characters)
./pyp2rpm/metadata_extractors.py:127:80: E501 line too long (80 > 79 characters)
./pyp2rpm/metadata_extractors.py:139:80: E501 line too long (98 > 79 characters)
./pyp2rpm/metadata_extractors.py:147:80: E501 line too long (98 > 79 characters)
./pyp2rpm/metadata_extractors.py:164:80: E501 line too long (87 > 79 characters)
./pyp2rpm/metadata_extractors.py:168:80: E501 line too long (113 > 79 characters)
./pyp2rpm/metadata_extractors.py:173:80: E501 line too long (92 > 79 characters)
./pyp2rpm/metadata_extractors.py:230:42: E127 continuation line over-indented for visual indent
./pyp2rpm/metadata_extractors.py:361:1: W293 blank line contains whitespace
./pyp2rpm/metadata_extractors.py:364:80: E501 line too long (87 > 79 characters)
./pyp2rpm/metadata_extractors.py:365:1: W293 blank line contains whitespace
./pyp2rpm/metadata_extractors.py:366:80: E501 line too long (84 > 79 characters)
./pyp2rpm/metadata_extractors.py:370:80: E501 line too long (83 > 79 characters)
./pyp2rpm/metadata_extractors.py:371:80: E501 line too long (88 > 79 characters)
./pyp2rpm/metadata_extractors.py:377:80: E501 line too long (80 > 79 characters)
./pyp2rpm/metadata_extractors.py:392:80: E501 line too long (90 > 79 characters)
./pyp2rpm/metadata_extractors.py:414:80: E501 line too long (95 > 79 characters)
./pyp2rpm/metadata_extractors.py:445:38: E127 continuation line over-indented for visual indent
./pyp2rpm/package_getters.py:39:80: E501 line too long (96 > 79 characters)
./pyp2rpm/package_getters.py:78:80: W291 trailing whitespace
./pyp2rpm/package_getters.py:81:5: E303 too many blank lines (2)
./pyp2rpm/package_getters.py:112:80: E501 line too long (91 > 79 characters)
./pyp2rpm/package_getters.py:114:80: E501 line too long (82 > 79 characters)
./pyp2rpm/package_getters.py:115:80: E501 line too long (114 > 79 characters)
./pyp2rpm/package_getters.py:117:80: E501 line too long (89 > 79 characters)
./pyp2rpm/package_getters.py:124:80: E501 line too long (88 > 79 characters)
./pyp2rpm/package_getters.py:128:80: E501 line too long (93 > 79 characters)
./pyp2rpm/package_getters.py:130:80: E501 line too long (88 > 79 characters)
./pyp2rpm/package_getters.py:150:80: E501 line too long (85 > 79 characters)
./pyp2rpm/settings.py:11:80: E501 line too long (96 > 79 characters)
./pyp2rpm/settings.py:16:80: E501 line too long (81 > 79 characters)
./pyp2rpm/settings.py:17:80: E501 line too long (82 > 79 characters)
./pyp2rpm/settings.py:18:80: E501 line too long (96 > 79 characters)
./pyp2rpm/settings.py:19:80: E501 line too long (101 > 79 characters)
./pyp2rpm/settings.py:20:80: E501 line too long (94 > 79 characters)
./pyp2rpm/settings.py:21:80: E501 line too long (84 > 79 characters)
./pyp2rpm/settings.py:24:80: E501 line too long (93 > 79 characters)
./pyp2rpm/settings.py:25:80: E501 line too long (104 > 79 characters)
./pyp2rpm/settings.py:26:80: E501 line too long (104 > 79 characters)
./pyp2rpm/utils.py:56:1: E302 expected 2 blank lines, found 1
./pyp2rpm/utils.py:110:1: E302 expected 2 blank lines, found 1
./pyp2rpm/utils.py:115:1: E302 expected 2 blank lines, found 1
./tests/test_convertor.py:12:1: E302 expected 2 blank lines, found 1
./tests/test_convertor.py:13:39: E251 unexpected spaces around keyword / parameter equals
./tests/test_convertor.py:13:41: E251 unexpected spaces around keyword / parameter equals
./tests/test_convertor.py:13:80: E501 line too long (81 > 79 characters)
./tests/test_convertor.py:14:31: E261 at least two spaces before inline comment
./tests/test_convertor.py:38:30: E251 unexpected spaces around keyword / parameter equals
./tests/test_convertor.py:38:32: E251 unexpected spaces around keyword / parameter equals
./tests/test_metadata_extractors.py:17:1: E302 expected 2 blank lines, found 1
./tests/test_metadata_extractors.py:25:80: E501 line too long (112 > 79 characters)
./tests/test_metadata_extractors.py:26:80: E501 line too long (111 > 79 characters)
./tests/test_metadata_extractors.py:27:80: E501 line too long (118 > 79 characters)
./tests/test_metadata_extractors.py:28:80: E501 line too long (118 > 79 characters)
./tests/test_metadata_extractors.py:29:80: E501 line too long (119 > 79 characters)
./tests/test_metadata_extractors.py:30:80: E501 line too long (127 > 79 characters)
./tests/test_metadata_extractors.py:31:18: E124 closing bracket does not match visual indentation
./tests/test_metadata_extractors.py:34:80: E501 line too long (98 > 79 characters)
./tests/test_metadata_extractors.py:35:80: E501 line too long (94 > 79 characters)
./tests/test_metadata_extractors.py:37:80: E501 line too long (85 > 79 characters)
./tests/test_metadata_extractors.py:107:21: E251 unexpected spaces around keyword / parameter equals
./tests/test_metadata_extractors.py:107:23: E251 unexpected spaces around keyword / parameter equals
./tests/test_metadata_extractors.py:107:80: E501 line too long (87 > 79 characters)
./tests/test_metadata_extractors.py:108:80: E501 line too long (115 > 79 characters)
./tests/test_metadata_extractors.py:109:21: E251 unexpected spaces around keyword / parameter equals
./tests/test_metadata_extractors.py:109:23: E251 unexpected spaces around keyword / parameter equals
./tests/test_metadata_extractors.py:110:80: E501 line too long (93 > 79 characters)
./tests/test_metadata_extractors.py:111:80: E501 line too long (86 > 79 characters)
./tests/test_metadata_extractors.py:129:15: E231 missing whitespace after ','
./tests/test_metadata_extractors.py:130:80: E501 line too long (85 > 79 characters)
./tests/test_metadata_extractors.py:138:1: E302 expected 2 blank lines, found 1
./tests/test_metadata_extractors.py:141:36: E261 at least two spaces before inline comment
./tests/test_metadata_extractors.py:143:80: E501 line too long (117 > 79 characters)
./tests/test_metadata_extractors.py:144:80: E501 line too long (117 > 79 characters)
./tests/test_metadata_extractors.py:145:18: E124 closing bracket does not match visual indentation
./tests/test_metadata_extractors.py:148:37: E261 at least two spaces before inline comment
./tests/test_metadata_extractors.py:149:22: E231 missing whitespace after ','
./tests/test_package_getters.py:40:80: E501 line too long (81 > 79 characters)
./tests/test_package_getters.py:41:80: E501 line too long (83 > 79 characters)
./tests/test_package_getters.py:42:80: E501 line too long (80 > 79 characters)
./tests/test_package_getters.py:45:18: E124 closing bracket does not match visual indentation
./tests/test_package_getters.py:74:80: E501 line too long (84 > 79 characters)
mcyprian commented 8 years ago

Everything should be fixed now, I have also run tool autopep8 to change formatting of modules violating pep8.

hroncok commented 8 years ago

Looks good to me. Didn't test the functions, as I trust your judgement and tests.