search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
128 stars 39 forks source link

License files #56

Closed mcyprian closed 8 years ago

mcyprian commented 8 years ago

Doc files are separated to license files and other doc files, License files are listed in %license section of the spec file instead of %doc. This PR also contains minor fix of created spec file's name when -s/--srpm option is set.

hroncok commented 8 years ago

More tests with different files? COPYRIGHT etc.?

mcyprian commented 8 years ago

Are there any other file names except /LICENSE /COPYRIGHT */COPYING that should be moved to %license?

hroncok commented 8 years ago

well, see for example https://github.com/encukou/py3c/blob/master/LICENSE.MIT https://github.com/encukou/py3c/blob/master/doc/LICENSE.CC-BY-SA-3.0 and similar.

mcyprian commented 8 years ago

Fixed.

hroncok commented 8 years ago

Everything except the cosmetic comment about the line break seems OK.

mcyprian commented 8 years ago

I think it looks a bit better now :) thanks for the review @hroncok.