search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
125 stars 39 forks source link

COPR issues #76

Closed nmilosev closed 7 years ago

nmilosev commented 7 years ago

Hello there!

When trying to build Keras from PyPI on COPR for F24 the build fails. Here is the log:

https://copr-be.cloud.fedoraproject.org/results/nmilosev/Keras/fedora-24-x86_64/00442293-python-Keras/build.log.gz

As you can see the build for Python 2.7 works fine, however when building for Python 3, there are several issues:

....
writing manifest file 'Keras.egg-info/SOURCES.txt'
Copying Keras.egg-info to /builddir/build/BUILDROOT/python-Keras-1.0.7-1.fc24.x86_64/usr/lib/python3.5/site-packages/Keras-1.0.7-py3.5.egg-info
running install_scripts
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 /builddir/build/BUILD/Keras-1.0.7
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32s, 0 CRC32s did match.

...

Processing files: python3-Keras-1.0.7-1.fc24.noarch
error: File not found: /builddir/build/BUILDROOT/python-Keras-1.0.7-1.fc24.x86_64/usr/lib/python3.5/site-packages/Keras_1.0.7_py3.4.egg_info
RPM build errors:
    File not found: /builddir/build/BUILDROOT/python-Keras-1.0.7-1.fc24.x86_64/usr/lib/python3.5/site-packages/Keras_1.0.7_py3.4.egg_info
Child return code was: 1
EXCEPTION: [Error()]
...

It tries to find /builddir/build/BUILDROOT/python-Keras-1.0.7-1.fc24.x86_64/usr/lib/python3.5/site-packages/Keras_1.0.7_py3.4.egg_info however it should be looking for: /builddir/build/BUILDROOT/python-Keras-1.0.7-1.fc24.x86_64/usr/lib/python3.5/site-packages/Keras-1.0.7-py3.5.egg-info

Several problems here:

  1. 3.5 vs 3.4
  2. after version (1.0.7) there is one time an underscore and the other one is dash (which even makes F23 builds fail)

I'm not sure if this is Keras related, COPR related, or pyp2rpm related.

Halp! :)

nmilosev commented 7 years ago

Tested locally (f24, py3.5.1) - everything is working fine. Any advice?

nmilosev commented 7 years ago

Another weird thing: https://copr.fedorainfracloud.org/coprs/nmilosev/Keras/build/442300/

You can see it's a f24 chroot, but it is bulding a fc23 package? So it is COPR related?

nmilosev commented 7 years ago

Uploading the SRPM works just fine: https://copr.fedorainfracloud.org/coprs/nmilosev/Keras/build/442301/ not sure what to do next

hroncok commented 7 years ago

cc @xsuchy

xsuchy commented 7 years ago

Another weird thing: https://copr.fedorainfracloud.org/coprs/nmilosev/Keras/build/442300/ You can see it's a f24 chroot, but it is bulding a fc23 package? So it is COPR related?

The SRPM has .fc23 because the SRPM is build on F23 machine. But the binary RPM is build normaly in f24 chroot. So that is not problem.

xsuchy commented 7 years ago

Tested locally (f24, py3.5.1) - everything is working fine. Any advice?

The machine which runs pyp2rpm is F23 so it using pyp2rpm-3.1.2-1.fc23.noarch. Not sure if this is the cause thou.

mcyprian commented 7 years ago

Package Keras can be now built successfully for both Python 2 and Python 3, closing this.

nmilosev commented 7 years ago

Thanks Michal! :)