search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
125 stars 39 forks source link

package rename option is ignored - importing Sphinx package with wrong name #87

Closed ssbarnea closed 7 years ago

ssbarnea commented 7 years ago

While trying to convert one of the most popular python packages Sphinx I found this bug.

pyp2rpm -r python-sphinx -d . --srpm Sphinx

Instead of generating a rpm for the package named python-sphinx it will generate python-Sphinx. Both filename and NAME-VERSION-RELEASE do contain python-Sphinx instead of python-Sphinx.

Base on Fedora naming convention I would even assume that the package name would be lowercases anyway, but that's not the case.

I would not mind making a pull request but first I want to understand which approach for fixing this would be preferred.

mcyprian commented 7 years ago

We should take a loot at #66 before fixing this issue. It is also related to pypi_name macro usage in the template.