search

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.
MIT License
128 stars 39 forks source link

Base Python version (`-b`) in metadata extraction #89

Closed irushchyshyn closed 7 years ago

irushchyshyn commented 7 years ago

Use the base Python version (if provided with -b option) to extract metadata by running setup.py for the package.

Fixes #90.

mcyprian commented 7 years ago

Everything seems to work fine except this case: I have pyp2rpm installed in virtualenvironment, I run command "pyp2rpm -b2 package" and extraction of metadata using python2 interpreter fails for some reason (e.g. python2 is not installed). After this happens pyp2rpm uses /usr/bin/python3 in second attempt to extract data instead of python3 inside virtualenv (/home/mcyprian/.virtualenvs/pyp2rpm/bin/python3). You can reference issue #90 in your commit.

irushchyshyn commented 7 years ago

@mcyprian Thank you for the comment. I have fixed the issue you have mentioned in e0b0b65. Now if the version supplied with -b option or the alternative version is a current executable, the executable will be used.

mcyprian commented 7 years ago

Approved.