Common review request issues

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.

MIT License

125 stars 39 forks source link

Closed irushchyshyn closed 7 years ago

irushchyshyn commented 7 years ago

This PR is intended to fix few common issues of the package review and make pyp2rpm follow the latest standards.

The issues are:

the use of %{summary} macro
soft links pattern: less specific -> more specific (see comemnt, and see RPM porting guide example)
the forse flag in ln command (see comment and RPM porting guide example)

mcyprian commented 7 years ago

All the changes are reasonable and don't affect number of successfully buiit packages of my test set. Ready to be merged.