Make `-r` option work (#87)

fedora-python / pyp2rpm

Tool to convert a package from PyPI to RPM SPECFILE or to generate SRPM.

MIT License

125 stars 39 forks source link

Make `-r` option work (#87) #94

Closed irushchyshyn closed 7 years ago

irushchyshyn commented 7 years ago

Introduce %{srcname} macro to be used alongside %{pypi_name} if the package name is to be changed (applies also for packages already starting with python- or Python- in PyPI)
Fix filters tests to work with the new signature for macroed_pkg_name
Add a new integration test for python-sphinx.spec
Corner case: fix searching for Sphinx directory, when it is tested itself (another doc/conf.py in tests folder)

Fixes issues #87 and #66.

mcyprian commented 7 years ago

There is also couple of packages containing "Python-" prefix on PyPI. Python-Crest for example, in this case result is following:

%global pypi_name Python-Crest

Name:           python-%{pypi_name}

Maybe we should cover this case as well.

irushchyshyn commented 7 years ago

There is also couple of packages containing "Python-" prefix on PyPI. Python-Crest for example, in this case result is following: %global pypi_name Python-Crest Name: python-%{pypi_name} Maybe we should cover this case as well.

Thanks for a suggestion. I have covered those packages in 2c7783f

irushchyshyn commented 7 years ago

This PR fixes also #66, right? Could you reference it in one of the commits? It seems to work fine for both cases:

name of the package is explicitly changed by -r option

original PyPI name contains python- prefix

Thanks for a review. I have referenced the issue in the PR description.

mcyprian commented 7 years ago

Works like a charm :)