search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Improved README #13

Closed Sanqui closed 7 years ago

Sanqui commented 7 years ago

Some things missing:

hroncok commented 7 years ago

From the previous PR:

Especially with project, that has a history with moving upstream, plese always reference issues and pull request in the commit messages with full URLs:

Fix https://github.com/fedora-python/python-ethtool/pull/2

Instead of:

Fix #2

GitHub will show it nicely anyway, but if the repo is moved, the numbers keep making sense.

Here I suggest to remove that line from the first commit completely as it does not fix the issue yet and either add it to the last commit once we agree on a completeness, or we can add it to the merge commit.

hroncok commented 7 years ago

Is this ready from your POV?

Sanqui commented 7 years ago

It looks good to me.

hroncok commented 7 years ago

Thanks @Sanqui, @frenzymadness.