search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Porting and fixing tests #19

Closed frenzymadness closed 7 years ago

hroncok commented 7 years ago

Does this obsolete https://github.com/fedora-python/python-ethtool/pull/18?

hroncok commented 7 years ago

BTW include/py3c/compat.h is not in sdist and tox cannot even attempt to compile this

frenzymadness commented 7 years ago

I am gonna cherry-pick your commits from #18 and merge these PRs. License and MANIFEST file fixed.

hroncok commented 7 years ago

I've seen a commit that made "Bring some CPython 2 helper code so we can run this" redundant by calling unittest.main() instead. Was it removed?

frenzymadness commented 7 years ago

Yes, I removed redundant commits during the merge.

hroncok commented 7 years ago

Did it not work? It was way better than my commit.

frenzymadness commented 7 years ago

Heh, I thought that your code is more complex and better.

I don't see any use case nor usage of soak tests so what about deleting this functionality?

frenzymadness commented 7 years ago

Seems like I won :smile:

stratakis commented 7 years ago

wow you nailed it guys

hroncok commented 7 years ago

Still WIP?

frenzymadness commented 7 years ago

@hroncok No, thanks.