search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Remove truncating from device name printing. #31

Closed frenzymadness closed 7 years ago

frenzymadness commented 7 years ago

Because there is a newline between device name and HW address in the new version of ethtool/pifconfig, truncating and left alignment doesn't make sense.

The question is whether we want a newline between device name and HW address because it was done by coincidence (IMHO) during changing the syntax to Python 3 compatible form by @hroncok. Commit: https://github.com/fedora-python/python-ethtool/commit/bedc6e11c74ac47501a063dce15ff5ce2fe4d90f

What do you think? Do we want this slightly different output of pifconfig? Could this change break something?

frenzymadness commented 7 years ago

The tests are failing because Travis updated image of virtual machine.

stratakis commented 7 years ago

The change LGTM.

hroncok commented 7 years ago

The tests are failing because Travis updated image of virtual machine.

Deleted all caches and restarting the build.

hroncok commented 7 years ago

Merge at will.

frenzymadness commented 7 years ago

Merged. IMHO it's not necessary to make a new release.