fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Link speed and autoneg #32

Closed briancline closed 7 years ago

briancline commented 7 years ago

The readme suggests link speed and autonegotiation can be queried and set, but in a cursory glance throughout it doesn't appear this is implemented. I might be wrong though.

Can you provide an example showing how to query link speed and autonegotiation?

hroncok commented 7 years ago

The readme suggests link speed and autonegotiation can be queried and set

Where exactly is this suggested?

briancline commented 7 years ago

It's in the intro section.

Sanqui commented 7 years ago

pethtool allows for setting coalesce and ring parameters, see usage. Granted, this is fairly specific kernel settings and not exactly what the README says, so it should probably be changed.

hroncok commented 7 years ago

@Sanqui Could you please update the README?

Sanqui commented 7 years ago

33 changes the README to be a bit less specific and more in line with the descriptions of the tools.

briancline commented 7 years ago

Thanks for clarifying a bit and for the quick responses. Are there any plans/desires for python-ethtool to support link speeds and auto-negotiation settings in the future?

frenzymadness commented 7 years ago

We took the maintenance of ethtool because we need Python 3 support but unfortunately, we don't have enough time to extend functionalities.

But if you want to add something, feel free to open PR and we'll do a review of your changes. Any help will be very appreciated.