search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Offloading: adding set_gso(), get_gro() and set_gso() #37

Closed RemyDelion closed 6 years ago

RemyDelion commented 6 years ago

Hello, As I needed these 3 functions, I created them locally. Please could you allow me to push the updates on a new branch? Next I will create the corresponding PR. Thanks in advance, Regards, Remy

stratakis commented 6 years ago

Hello @RemyDelion and thanks for your interest in python-ethtool. You can fork the repository on github and push your changes there, either to your master or to a different branch of your repo.

Then you should have a button to create a PR against our repository, and we can review your code.

Please post here if you require more help in regards to this issue or the procedure.

frenzymadness commented 6 years ago

Here you can find a simple howto https://gist.github.com/Chaser324/ce0505fbed06b947d962

RemyDelion commented 6 years ago

Thank you! Id did the PR https://github.com/fedora-python/python-ethtool/pull/38.

frenzymadness commented 6 years ago

Closing this issue

RemyDelion commented 6 years ago

Hi frenzymadness, Did you merge the PR https://github.com/fedora-python/python-ethtool/pull/38? I can't see the updated files in Master or libnl-1 branches... Regards, Remy

frenzymadness commented 6 years ago

Hello.

No, I've just closed this issue where we discussed how to create a PR without special rights. PR #38 is still open and waiting for a second review.

If you want, we can keep both (issue and PR) open.