search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

Offload: adding set_gso(), get_gro() and set_gro() functions #38

Closed RemyDelion closed 6 years ago

RemyDelion commented 6 years ago

https://github.com/fedora-python/python-ethtool/issues/37

frenzymadness commented 6 years ago

Thank you very much for your PR. It looks good to me but it needs one more review.

@stratakis could you please take a look?

stratakis commented 6 years ago

I am not so familiar with python-ethtool's codebase to do a review of such a new feature. @hroncok would you be able to chip in?

Also I see that some executable bits were removed in this PR (permissions changing from 755 to 644) on some files. Is this intentional?

RemyDelion commented 6 years ago

Concerning the permissions, no, it wasn't intentional. I didn't want to change any permission.

hroncok commented 6 years ago

@hroncok would you be able to chip in?

Not really, sorry.

frenzymadness commented 6 years ago

Okay, our last chance, @encukou?

RemyDelion commented 6 years ago

I just fixup the file permissions (to 755).

lootr commented 6 years ago

That sounds great to me :)

frenzymadness commented 6 years ago

Okay, I don't see any reason why not merge this PR.

Thank you for your contribution!

RemyDelion commented 6 years ago

Thanks!